feat: bumped React Native and Expo version #4477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kamilkedzierski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Contributor
|
This looks good, I only found 2 issues. What I think it is from this PR, is on iOS when switching to RTL, the app restarts infinitely. Screen.Recording.2024-09-28.at.19.52.15.mp4Can we fix that? |
gedu
reviewed
Sep 28, 2024
Here is the FAB issue for future reference. |
Contributor
|
RTL update LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We needed to bump the Android SDK version (see the attached screenshot for details). To accommodate this, we also had to update React Native and Expo, as the versions we were using were outdated and no longer supported.
Summary:
Version Updates:
Issues Encountered & Resolved:
All issues were resolved after the updates.
Related issue
Test plan
I would appreciate it if the reviewer could double-check the example app to ensure that no bugs were missed during the update. 🙏